At first quick look, i catched various bugs present in 1.0.1eta that were not corrected :
1/ Emails sent to moderators
in post.php line 270 the following code allows to construct the url which is included in the email :
| Code: |
//construct a useable URL
$messageUrl = sefRelToAbs(JB_LIVEURLREL . "&func=view&catid=$catid&id=$pid"«») . "#$pid";
|
This code is written ONLY for the subscription notification emails. It is forgotten before constructing the moderator notification emails, so the line :
| Code: |
$msg .= "URL: $messageUrl\n\n";
|
is effective ONLY IF THE SUBSCRIPTIONS ARE ALLOWED. There is no link in the email otherwise.
A simple copy/paste solves the problem...
2/ Pages loaded twice
Using the FireBoard session decreases significantly the loading speed of FireBoard. This has already been discussed
in this post.
3/ Whoisonline plugin
When you are done browsing the forum, you click on the "logout" button located in the profilebox. If you come back on home page to see who is online you'll have a surprise : you are still visible in the "whoisonline plugin" !
The problem comes from these two facts :
- that whoisonline.php uses the FireBoard session to determine who is online :
| Code: |
$query
= "SELECT w.userip, w.time, w.what, u.username, u.id, k.moderator, k.showOnline "
. "\n FROM #__fb_whoisonline AS w" . "\n LEFT JOIN #__users AS u ON u.id=w.userid " . "\n LEFT JOIN #__fb_users AS k ON k.userid=w.userid " . "\n WHERE w.userid!=0 " . "\n ORDER BY w.time DESC";
|
and
- the links "logout" in the profilebox disconnects from the Joomla session :
| Code: |
$logoutlink = sefRelToAbs('index.php?option=logout');
|
Other suggestions (no bug here)
- It is not difficult to allow the use of png's OR gifs for the design. I made a hack that you can see
here (see that all icons are png's), modifying icons.php for the buttons and some codes in /template/default directory. By the way please notice that the topic icons are still hardcoded (not defined in icons.php or any other way to change them easyly).
This is a big problem if it is needed to change the template : dark gif icons will show poorly on clear backgrounds and vice versa.
- The new admin design seems very messy !! I'm not sure at all that the left bar will help newbies...
4/ W3C compliance
It would decrease the number of errors if the code were W3C compliant !!
==> It would be great to debug FireBoard before adding new features !
Favoured: 1
It should have been good to solve them before going forward in the development.
