Best of joomla gives you news, joomla templates, tutorials and websites about Joomla , FireBoard and FireMessage official page.
| No account yet?   |
The FireBoard forum component development is still going on. In order to get better, FireBoard will be moved from the Best of Joomla website.
During this transition period, the forum in Best of Joomla will be closed to new posts.
Welcome, Guest
Please Login or Register.    Lost Password?
FireBoard Manual Latest release discussions Download FireBoard
Re:Possible to reply on closed topics in 1.04 (1 viewing) (1) Guest
TOPIC: Re:Possible to reply on closed topics in 1.04
#37233
[SOLVED]Possible to reply on closed topics in 1.04 1 Year ago  
If you use the latest message link on the right in the thread overview you can still reply on closed topics.

I checked the code and fixed it where it goes wrong is the lock and unlock actions in post.php they are based on the message ID where it should be the thread ID so all the messages in the thread get locked.

If you guys want I can post my fix. (its in view.php (to send the thread ID) and post.php (to change some queries).
dsmink (User)
Junior Boarder
Posts: 31
graphgraph
User Offline Click here to see the profile of this user
Gender: Male Cleverinsert B.V. Location: Netherlands Birthdate: 1983-09-25
Logged Logged
 
Last Edit: 2008/01/25 14:54 By dsmink.
 
 
#37237
Re:Possible to reply on closed topics in 1.04 1 Year ago  
Yes, please post the fix here! And open a bug in the bug tracker at Joomlacode - this is a crucial bug that should be taken care of!
hypnotoad (User)
Senior Boarder
Posts: 111
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
 
#37240
Re:Possible to reply on closed topics in 1.04 1 Year ago  
Bugtracker: joomlacode.org/gf/project/fireboard/trac...tracker_item_id=9021

View.php:

Lock button:
Replace line: 1224
[code:1]$msg_lock = "id .'&catid=' . $catid) . "">";[/code:1]
With:
[code:1]$msg_lock = "thread . '&id=' . $fmessage->id .'&catid=' . $catid) . "">";[/code:1]

Unlock button:
Replace line: 1237
[code:1]$msg_lock = "id .'&catid=' . $catid) . "">";[/code:1]
With:
[code:1]$msg_lock = "thread . '&id=' . $fmessage->id .'&catid=' . $catid) . "">";[/code:1]
[b]
Post.php:[/b]

On line 641 (after [code:1]$id = (int)$id;[/code:1]) add:
[code:1]$thread = (int)$thread;[/code:1]

Lock function:
Replace line 1190:
[code:1]$database->setQuery("update #__fb_messages set locked=1 where id=$id"«»);[/code:1]
With:
[code:1]$database->setQuery("update #__fb_messages set locked=1 where thread=$thread"«»);[/code:1]

Unlock function:
Replace line 1217:
[code:1]$database->setQuery("update #__fb_messages set locked=0 where id=$id"«»);[/code:1]
With:
[code:1]$database->setQuery("update #__fb_messages set locked=0 where thread=$thread"«»);[/code:1]
dsmink (User)
Junior Boarder
Posts: 31
graphgraph
User Offline Click here to see the profile of this user
Gender: Male Cleverinsert B.V. Location: Netherlands Birthdate: 1983-09-25
Logged Logged
 
Last Edit: 2008/01/04 19:41 By dsmink.
 
 
#37241
Re:Possible to reply on closed topics in 1.04 1 Year ago  
Hmm it wont let me post the complete line of code for view.php :/
dsmink (User)
Junior Boarder
Posts: 31
graphgraph
User Offline Click here to see the profile of this user
Gender: Male Cleverinsert B.V. Location: Netherlands Birthdate: 1983-09-25
Logged Logged
 
 
#39532
Re:Possible to reply on closed topics in 1.04 11 Months, 3 Weeks ago  
Taht's good,

But the quick reply still works.

Please continue to fix!
viet4777 (User)
Senior Boarder
Posts: 291
graphgraph
User Offline Click here to see the profile of this user
Luyenkim.NET
Logged Logged
 
Luyenkim.Net
utf-8 Vietnamese language package will be complete in mid of Oct.
luyenkim.net/home9/index.php?option=com_...5&id=282#282
 
 
#39533
Re:Possible to reply on closed topics in 1.04 11 Months, 3 Weeks ago  
You can still reply on closed topics?

Check out the fix I posted in the bugtracker please.
dsmink (User)
Junior Boarder
Posts: 31
graphgraph
User Offline Click here to see the profile of this user
Gender: Male Cleverinsert B.V. Location: Netherlands Birthdate: 1983-09-25
Logged Logged
 
 
#39538
Re:Possible to reply on closed topics in 1.04 11 Months, 3 Weeks ago  
Thank,
I have some modified before so I can not upload all your files.

But I found my fixed quick post for 1.0.3, and It also fixes for FB 1.0.4:

luyenkim.net/home9/index.php?option=com_...d=5&id=1154#1154

My fix is not good, could you tell me more about your fix so that i can modify my FB files.
viet4777 (User)
Senior Boarder
Posts: 291
graphgraph
User Offline Click here to see the profile of this user
Luyenkim.NET
Logged Logged
 
Last Edit: 2008/01/18 14:41 By viet4777.
 
Luyenkim.Net
utf-8 Vietnamese language package will be complete in mid of Oct.
luyenkim.net/home9/index.php?option=com_...5&id=282#282
 
 
#39539
Re:Possible to reply on closed topics in 1.04 11 Months, 3 Weeks ago  
Instead of locking the thread on the message ID I altered the SQL statement to lock it on thread ID so that all the messages in the thread get locked and not just the first one.

If only the first message is locked its possible to use quick reply to reply via the other messages.
dsmink (User)
Junior Boarder
Posts: 31
graphgraph
User Offline Click here to see the profile of this user
Gender: Male Cleverinsert B.V. Location: Netherlands Birthdate: 1983-09-25
Logged Logged
 
 
#39541
Re:Possible to reply on closed topics in 1.04 11 Months, 3 Weeks ago  
dsmink wrote:
Instead of locking the thread on the message ID I altered the SQL statement to lock it on thread ID so that all the messages in the thread get locked and not just the first one.

If only the first message is locked its possible to use quick reply to reply via the other messages.


It means from now, all the thread with the first message is locked then all messages in the thread will be locked also.

And all the locked threads had posted before, the quick post still is possible!
viet4777 (User)
Senior Boarder
Posts: 291
graphgraph
User Offline Click here to see the profile of this user
Luyenkim.NET
Logged Logged
 
Luyenkim.Net
utf-8 Vietnamese language package will be complete in mid of Oct.
luyenkim.net/home9/index.php?option=com_...5&id=282#282
 
 
#39542
Re:Possible to reply on closed topics in 1.04 11 Months, 3 Weeks ago  
Yep thats correct. On my forum I went through all the locked threads and relocked them.
dsmink (User)
Junior Boarder
Posts: 31
graphgraph
User Offline Click here to see the profile of this user
Gender: Male Cleverinsert B.V. Location: Netherlands Birthdate: 1983-09-25
Logged Logged
 
 
Go to top