looks like someone only tested the release with error_reporting set quite low so it didn't show NOTICE errors...
I had a short look into the files, and for some of the variables notices were shown in my installation, e.g. msg_skype:
Am I right that it should get defined in view.php and then displayed by message.php? the only place in view.php where msg_skype gets defined is in line 964 after the following condition:
| Code: |
if ($userinfo->SKYPE != '') {
|
so if that doesn't apply, the variable is not set tuhs resulting in the NOTICE
(I don't know the condition's details though so I can only guess that there is a circumstance where this happens)
I also had a look into $msg_avatar which wasn't set in my case. It should get loaded from the CB profile but in the responsible lines 543ff. Let's have a look at lines 552ff
| Code: |
$database->setQuery("SELECT avatar FROM #__comprofiler WHERE user_id='$fmessage->userid' AND avatarapproved='1'"«»);
$avatar = $database->loadResult();
if ($avatar != '')
|
what if the DB query is unsuccessful (avatar not approved or the user simply does not have one)? is $avatar empty then? I guess so, and that is why the variable is unset.
Looks like there is no clean and quick fix to this since although you might change
| Code: |
if ($msg_skype) {
echo $msg_skype;
}
|
in messages.php, ll 119-121 and similar variables to:
| Code: |
if (!empty($msg_skype)) {
echo $msg_skype;
}
|
I'll probably wait for a new release because it looks like there are several variables and the 1500 lines large view.php which doesn't that developer friendly either, does not really motivate me to search for undefined variables...
Favoured: 9
