What I have done now, with leigh's help is - my fireboard.php from line 262 to 269 looks like this:

Code:

// do not reload the page if user is posting :: TODO: check if it cab be replaced by mosRedirect             if ($func != "post"«») { mosRedirect($_SERVER['REQUEST_URI']); die(); /*  echo 'setTimeout("window.location.reload( true )",100);'; */

As of now, it is working fine... have to wait and see if I get any complaints from other users. Anyway, it was an intermittent problem, so it may take some time before I can confirm the fix.

Best regards

Does anyone have a final working fireboard.php file with theses edits they can share - or does the one in SVN already have this fix?

Thanks

Greg

There is only one edit, I think

in fireboard.php file find

Code:

{ //grant them 30 minutes of inactivity; then recheck privileges and try to send them back where they came from setQuery("UPDATE #__fb_sessions SET allowed='na', readtopics='' where userid=$my->id");             $database->query();             setcookie("fboard_settings[prevvisit]", $fbSession->lasttime, time() + 31536000, '/');             // do not reload the page if user is posting :: TODO: check if it cab be replaced by mosRedirect             if ($func != "post") {                 echo 'setTimeout("window.location.reload( true )",100);';             }         }         $database->setQuery("UPDATE #__fb_sessions SET lasttime=$systime where userid=$my->id");         $database->query();     }

replace it with this (changes are in red color)

{ //grant them 30 minutes of inactivity; then recheck privileges and try to send them back where they came from
$database->setQuery("UPDATE #__fb_sessions SET lasttime=$systime, allowed='na', readtopics='' where userid=$my->id";
$database->query();
setcookie("fboard_settings[prevvisit]", $fbSession->lasttime, time() + 31536000, '/';

// do not reload the page if user is posting :: TODO: check if it cab be replaced by mosRedirect
if ($func != "post" {
$self_url = sprintf('http%s://%s%s',
(isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == TRUE ? 's': '',
$_SERVER['HTTP_HOST'],
$_SERVER['REQUEST_URI']
);
mosRedirect($self_url);
die();
//echo 'setTimeout("window.location.reload( true )",100);';
}
}

$database->setQuery("UPDATE #__fb_sessions SET lasttime=$systime where userid=$my->id";
$database->query();
}

OK I think I have added all that all fine and the double load issues appears fixed. However every now and then I get an error as it tries to load www.mydomain.com/http://www.mydomain.com/comp.....

Clicking back on the browser (FF2 and IE7) and then reselecting the menu item it works fine - any ideas why it is doing this - note I am using also Joomsef 1.5.1.

Thanks

Greg

I did not observe this behavior on my server, but can be that yours sometimes sets up those two $_SERVER variable (or at least one of them) incorrectly. If you believe that this code is in fact code causing the error, well, we can adjust code to search and remove second incorrect portion, which most probably will be present in $_SERVER['REQUEST_URI'] variable:

$new_URI = str_replace("".$_SERVER['HTTP_HOST'], "", $_SERVER['REQUEST_URI']);
$new_URI = str_replace("".$_SERVER['HTTP_HOST'], "", $new_URI);

$self_url = sprintf('http%s://%s%s', (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == TRUE ? 's': '', $_SERVER['HTTP_HOST'], $new_URI );
mosRedirect($self_url);

Thanks will give that a try. Are you able to attach your edited working fireboard.php file so I can compare it with mine.

Cheers

Greg

OK.


I have been trying to get these patches to work for weeks and finally think i got it working - without the glitches.

I had the problem others have had that with the basic patch I had an occasional
(perhaps 1 in 20) glitch where the URL created looked like:

www.mysite.com/http://www.mysite.com/forum

I used the patch code provided by prutkar earlier in this thread PLUS
his idea to search the URL string and strip out the excess copy of the base URL.

I wrote my own code for this last bit...here is the complete patch with my addition highlighted in red:

if ($inactivePeriod setQuery("UPDATE #__fb_sessions SET lasttime=$systime, allowed='na', readtopics='' where userid=$my->id";
$database->query();
setcookie("fboard_settings[prevvisit]", $fbSession->lasttime, time() + 31536000, '/';

// do not reload the page if user is posting :: TODO: check if it cab be replaced by mosRedirect
if ($func != "post" {
//echo 'setTimeout("window.location.reload( true )",100);';
$self_url = sprintf('http%s://%s%s',
(isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == TRUE ? 's': '',
$_SERVER['HTTP_HOST'],
$_SERVER['REQUEST_URI']
);
if (strripos($self_URL,"http:" != 0)
{
$self_url=substr($self_url,strripos($self_URL,"http:");
}

if (strripos($self_URL,"https:" != 0)
{
$self_url=substr($self_url,strripos($self_URL,"https:");
}
mosRedirect($self_url);
die();
}
}

Hmm ok I tried that but got an error.

Parse error: syntax error, unexpected T_STRING in /home/myname/public_html/components/com_fireboard/fireboard.php on line 255

It would be great if one of the devs could provide an official fix please - one that can be accessed by all, maybe release a FB1.0.3a or 1.0.4 or as requested release an official fireboard.php fix.

Thanks

Greg

Completely confused. Can someone please post the complete fireboard.php after fixing double page load and incorrect url issue.

Thanx a bunch from me and from those who are gonna download it too..

Regards,
Carty..

Any progress on this or is it on hold like anything else?