Best of joomla gives you news, joomla templates, tutorials and websites about Joomla , FireBoard and FireMessage official page.
| No account yet?   |
Welcome, Guest
Please Login or Register.    Lost Password?
FireBoard Manual Latest release discussions Download FireBoard Spread FireBoard!
Re:Split | Merge | Move topics (1 viewing) (1) Guest
Go to bottom Favoured: 13
TOPIC: Re:Split | Merge | Move topics
#42568
Re:Split | Merge | Move topics 9 Months, 3 Weeks ago  
There's something new that's happening which is strange.

The topic that I want to split is a sticky topic. After the failed attempt to split posts from it FB now lists it as the very last post in that board (i.e. as if it was the first post in the board); ignoring the "sticky" bit.

If I unsticky it then it presented as the first thread in that board (which is correct because it also has had the newest reply entered into it).

If I then "sticky" it again it is listed at the top of the board's posts as it should then be (no other sticky topics) *but* the posts that I wanted split (from the end of the thread) now appear as the first posts in that that thread and everything else has been moved down the list.



PS, if I replace the original 4 altered files then all is well again (but I can't split the topic )
sastrugi (User)
Fresh Boarder
Posts: 11
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
Last Edit: 2008/02/03 01:14 By sastrugi.
 
The administrator has disabled public write access.  
#42585
Re:Split | Merge | Move topics 9 Months, 3 Weeks ago  
sastrugi:
Thanks for this info. The sticky bit is something I haven't taken into account and it must be the cause for this strange behavior. Can you confirm that you can use the functions successfully on regular topics but not on sticky ones? If you confirm that, I'll start working on a revision.

P. S.
I reproduced this behavior on my site and it seems that I need to revise the mod substantially. For now, it is confirmed that setting the sticky bit on a topic makes the split function behave erratically. This is because it employs the same parameter (ordering) as the sticky function. I have to revise to make the two co-exist peacefully. Standby.
gomjabbar (User)
Senior Boarder
Posts: 112
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
Last Edit: 2008/02/03 03:16 By gomjabbar.
 
Gossper - One Forum to Rule Them All
 
The administrator has disabled public write access.  
#42660
Re:Split | Merge | Move topics 9 Months, 3 Weeks ago  
Here's an updated version of the mod with alterations to the two functions. If you are using the sticky bit (aka featured threads) in your forum, then you would want to update the merge and split functions inside post.php very soon. The previous versions of the mod are incompatible with any use of the sticky bit.

Note that I haven't had time to test this code change so if anyone with a beta forum could do that and report, I'm sure we'll all be grateful.
File Attachment:
File Name: Merge_Split_v.txt
File Size: 26071
gomjabbar (User)
Senior Boarder
Posts: 112
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
Gossper - One Forum to Rule Them All
 
The administrator has disabled public write access.  
#44835
Re:Split | Merge | Move topics 9 Months ago  
Sticky topics are still acting strange. When replyed to, the first message of the topic is last. Topic starts with message 2, followed by 3,4,5 and so on, and last the first message.
keltic (User)
Fresh Boarder
Posts: 5
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
The administrator has disabled public write access.  
#47645
Re:Split | Merge | Move topics 8 Months ago  
After converting my SMF forum to FB and with well over 2000 posts getting all split up (replys created as new posts etc..) this feature is a life saver... just installed tonight and I am already merging back together split posts... love it . thank you very much for your efforts!

Using J1.0.12 -FB 1.0.4 only tested the Merge function...all is well so far!
llema (User)
Fresh Boarder
Posts: 14
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
The administrator has disabled public write access.  
#47672
Re:Split | Merge | Move topics 8 Months ago  
I have to apologize--real life has been preventing me from resolving the sticky bit incompatibility. I may have more time next week--there's light at the end of the tunnel.
gomjabbar (User)
Senior Boarder
Posts: 112
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
Gossper - One Forum to Rule Them All
 
The administrator has disabled public write access.  
#47673
Re:Split | Merge | Move topics 8 Months ago  
gomjabbar wrote:
I have to apologize--real life has been preventing me from resolving the sticky bit incompatibility. I may have more time next week--there's light at the end of the tunnel.

That is good news Gomjabbar. Similar things have kept me away from wanting to use the mod, until yesterday, strangely enough.

I downloaded the latest/last Merge_split_v.txt just to start from scratch with my FB install and I noticed a small typo in there:

The text says


5. And last but most important--the actual functions! In post.php, after the lines:

(code)

//begin merge function

else if ($do == "merge"
etc., etc.




When I think it's lost a paragraph and should read



5. And last but most important--the actual functions! In post.php, after the lines:

(code)

?php echo _POST_TOPIC_NOT_MOVED; ?

a href = "?php echo sefRelToAbs(JB_LIVEURLREL."&func=view&catid=$catid&id=$id";?"?php echo _POST_CLICK; ?/a

?php
}
}
(/code)

(code)

//begin merge function

etc., etc



(I've removed all of the code-tags to try and get it to display


Thanks for the good work and I hope you'e able to get this sorted soon

Cheers
sastrugi (User)
Fresh Boarder
Posts: 11
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
Last Edit: 2008/03/24 20:06 By sastrugi.
 
The administrator has disabled public write access.  
#48094
Re:Split | Merge | Move topics 7 Months, 3 Weeks ago  
Shout the 2 new buttons be on every entry in the topic or in the startentry only? If i put the //merge-split mod: inside the view.php after the $msg_edit .= "</a>"; i see nothing, only if i put it after if ($is_moderator && $showedEdit != 1) but then i have it in every post.
n0fear (User)
Junior Boarder
Posts: 24
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
The administrator has disabled public write access.  
#48279
Re:Split | Merge | Move topics 7 Months, 3 Weeks ago  
I am thinking of using this on a live Forum. From the posts here it is hard to tell if this is actually functional or if it will cause problems and not function correctly. Is this working for everyone? Let me know.

Thanks.
Further (User)
Junior Boarder
Posts: 20
graphgraph
User Offline Click here to see the profile of this user
Logged Logged
 
The administrator has disabled public write access.  
#48281
Re:Split | Merge | Move topics 7 Months, 3 Weeks ago  
Further wrote:
I am thinking of using this on a live Forum. From the posts here it is hard to tell if this is actually functional or if it will cause problems and not function correctly. Is this working for everyone? Let me know.

Thanks.


i used briefly on elektron-users.com but my sticky's got all fckd up so i took it out. i'd love to use this functionality once it's more stable.
actuel (User)
Junior Boarder
Posts: 21
graphgraph
User Offline Click here to see the profile of this user
Elektron-Users
Logged Logged
 
The administrator has disabled public write access.  
Go to top